refactor: Display member role when user has no role #1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have an Admin and a Member. The treatment of the Member looks good, but now (don't know if it's new) if I give the Member another role, that role shows up with a comma. |
|
@presleyp this is interesting, good catch! Is it on local our storybook? |
local. I'm doing |
|
@presleyp it is fixed, but probably you have to restart the app and the database because it was sending the fallback role to the API when it should not. |
Kira-Pilot
approved these changes
Jun 1, 2022
|
I'm still seeing the bugs, but if Kira isn't, you're good to go! |
|
Sorry, was late on this one, but yeah - everything looks good to me |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1949