From 95353c9e72555939d3120203dee966b45f917476 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Tue, 2 Sep 2025 14:28:48 +0200 Subject: [PATCH 1/3] fix: show popup on successful template build --- .../pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx index e6437b49d6d43..bee3f01d77e21 100644 --- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx +++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx @@ -21,7 +21,7 @@ import { TopbarDivider, TopbarIconButton, } from "components/FullPageLayout/Topbar"; -import { displayError } from "components/GlobalSnackbar/utils"; +import { displayError, displaySuccess } from "components/GlobalSnackbar/utils"; import { Loader } from "components/Loader/Loader"; import { TriangleAlertIcon } from "lucide-react"; import { ChevronLeftIcon } from "lucide-react"; @@ -178,6 +178,7 @@ export const TemplateVersionEditor: FC = ({ templateVersion.job.status === "succeeded" ) { setDirty(false); + displaySuccess(`Template version "${previousVersion.current.name}" built successfully.`); } previousVersion.current = templateVersion; }, [templateVersion]); From 77bc4c9fec10c053e708e3674f54e791ad2e1599 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Tue, 2 Sep 2025 14:33:50 +0200 Subject: [PATCH 2/3] unit test --- .../TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx index 999df793105a3..0207ac2c6d024 100644 --- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx +++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx @@ -104,6 +104,7 @@ const buildTemplateVersion = async ( }); await user.click(buildButton); await within(topbar).findByText("Success"); + await screen.findByText(`Template version "${templateVersion.name}" built successfully.`); }; test("Use custom name, message and set it as active when publishing", async () => { From 0b0dd49898cc2e29741036d8315249edcf4eb9c9 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Tue, 2 Sep 2025 14:43:25 +0200 Subject: [PATCH 3/3] fmt --- .../pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx | 4 +++- .../TemplateVersionEditorPage.test.tsx | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx index bee3f01d77e21..0779496b2295a 100644 --- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx +++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx @@ -178,7 +178,9 @@ export const TemplateVersionEditor: FC = ({ templateVersion.job.status === "succeeded" ) { setDirty(false); - displaySuccess(`Template version "${previousVersion.current.name}" built successfully.`); + displaySuccess( + `Template version "${previousVersion.current.name}" built successfully.`, + ); } previousVersion.current = templateVersion; }, [templateVersion]); diff --git a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx index 0207ac2c6d024..323befa8e96c3 100644 --- a/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx +++ b/site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx @@ -104,7 +104,9 @@ const buildTemplateVersion = async ( }); await user.click(buildButton); await within(topbar).findByText("Success"); - await screen.findByText(`Template version "${templateVersion.name}" built successfully.`); + await screen.findByText( + `Template version "${templateVersion.name}" built successfully.`, + ); }; test("Use custom name, message and set it as active when publishing", async () => {