Don't use parameters to pass secrets to GCP or AWS #2039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
bpmct
approved these changes
Jun 3, 2022
Comment on lines
+84
to
+88
| The way these generally work is via the credentials being available to Coder either in some | ||
| well-known location on disk (e.g. `~/.aws/credentials` for AWS on posix systems), or via | ||
| environment variables. It is usually sufficient to authenticate using the CLI or SDK for the | ||
| cloud provider before running Coder for this to work, but check the Terraform provider | ||
| documentation for details. |
Comment on lines
+13
to
+18
| ## Authentication | ||
|
|
||
| This template assumes that coderd is run in an environment that is authenticated | ||
| with AWS. For example, run `aws configure import` to import credentials on the | ||
| system and user running coderd. For other ways to authenticate [consult the | ||
| Terraform docs](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#authentication-and-configuration). |
There was a problem hiding this comment.
Currently, this isn't really be visible when creating a template via coder templates init. I added a mock "variable" in the Docker example, but I'm not really happy with this.
Any ideas? Perhaps it's also fair to rely on the default Terraform errors (+ these docs) to warn users.
There was a problem hiding this comment.
Yeah, I don't like the idea of hijacking parameters to guide end users. If we can't expect users to read the README in the examples, and want do do some handholding, we should build out a guided template init
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Don't use parameters to pass secrets to GCP or AWS Signed-off-by: Spike Curtis <spike@coder.com> * Fix fmt Signed-off-by: Spike Curtis <spike@coder.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of several PRs for #1967
This updates the AWS and GCP templates. I'd like to also do Kubernetes and Digital Ocean, but I'll need to chase down credentials and/or a test cluster, so let's not block this PR on that.