Skip to content

chore: Linter rule for properly formatted api errors #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 7, 2022
Merged

chore: Linter rule for properly formatted api errors #2123

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6970d2b
chore: Linter rule for properly formatted api errors
Emyrk Jun 7, 2022
0ca30a0
Fix all linting errors
Emyrk Jun 7, 2022
0e66d8a
Update comment
Emyrk Jun 7, 2022
5134987
Fix error check in test
Emyrk Jun 7, 2022
b813011
fixup! Fix error check in test
Emyrk Jun 7, 2022
173cf26
Remove comment
Emyrk Jun 7, 2022
1b2ef83
Add omitempty to 'Detail' field
Emyrk Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add omitempty to 'Detail' field
  • Loading branch information
@Emyrk
Emyrk committed Jun 7, 2022
commit 1b2ef8377e8bcce1e3f80e2a49a6dea716dbe16a
2 changes: 1 addition & 1 deletion coderd/httpapi/httpapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type Response struct {
// err.Error() text.
// - "database: too many open connections"
// - "stat: too many open files"
Detail string `json:"detail"`
Detail string `json:"detail,omitempty"`
// Validations are form field-specific friendly error messages. They will be
// shown on a form field in the UI. These can also be used to add additional
// context if there is a set of errors in the primary 'Message'.
Expand Down