Skip to content

fix: flaky install.sh upgrade on OSX (zsh killed) #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2022
Merged

fix: flaky install.sh upgrade on OSX (zsh killed) #2309

merged 2 commits into from
Jun 15, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Jun 13, 2022 •
edited
Loading

Fixes #2086. This likely has something to do with how MacOS trusts binaries

To test

@misskniss @mark-theshark - would appreciate if you could confirm this fixes it

Broken:

# see the current version
coder --version
# install a different version of Coder (n+1 or n-1)
curl -L https://raw.githubusercontent.com/coder/coder/main/install.sh | sh -s -- --version=0.6.6
# run the binary
coder version
# [1]    48010 killed     coder

Fixed:

# see the current version
coder --version
# install a different version of Coder (n+1 or n-1)
curl -L https://raw.githubusercontent.com/coder/coder/bpmct/install-fixes/install.sh | sh -s -- --version=0.6.6
# run the binary
coder
# Coder v0.6.6+cbde8e8 Mon Jun 13 14:16:26 UTC 2022
# https://github.com/coder/coder/commit/cbde8e8b91097412b2ae0daa72d1b698b61584bc!

@bpmct bpmct self-assigned this Jun 13, 2022
bpmct
bpmct commented Jun 13, 2022
View reviewed changes
install.sh
Comment on lines -88 to +89
Standalone release has been installed into $STANDALONE_INSTALL_PREFIX/bin/$STANDALONE_BINARY_NAME

Standalone release has been installed into $STANDALONE_INSTALL_PREFIX/bin/$STANDALONE_BINARY_NAME
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a lil bit of formatting here

bpmct
bpmct commented Jun 13, 2022
View reviewed changes
install.sh Outdated
Comment on lines 397 to 401
# Remove the file if it already exists to
# avoid https://github.com/coder/coder/issues/2086
if [ -f "$COPY_LOCATION" ]; then
"$sh_c" rm $COPY_LOCATION
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mv would also work here instead of cp.

https://developer.apple.com/forums/thread/130313?answerId=410704022#410704022

misskniss
misskniss approved these changes Jun 13, 2022
View reviewed changes
Copy link

@misskniss misskniss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it for me. Thanks @bpmct !

@bpmct bpmct merged commit 8f7dbee into main Jun 15, 2022
@bpmct bpmct deleted the bpmct/install-fixes branch June 15, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misskniss misskniss misskniss approved these changes

@sharkymark sharkymark Awaiting requested review from sharkymark

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coder gets zsh killed on macOS (not M1) after curl installing 0.6.2 AMD64 build
2 participants
@bpmct @misskniss