Skip to content

feat: improve terraform template parsing errors #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2022
Merged

feat: improve terraform template parsing errors #2331

merged 3 commits into from
Jun 15, 2022

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Jun 14, 2022 •
edited by ericpaulsen
Loading

Improves error output from parsing errors (fig. 1) caused by invalid HCL syntax.

Fixes provision job to send error logs from terraform init so we can catch terraform config validation errors (fig. 2).

fig. 1
Code_DB4Dt3ARkO

fig. 2
Code_UFwAaOTakJ

Fixes #1583
Fixes #2332

@deansheather deansheather marked this pull request as ready for review June 14, 2022 23:47
@deansheather deansheather requested a review from kylecarbs June 14, 2022 23:47
@bpmct
Copy link
Member

bpmct commented Jun 15, 2022

🙌 I had been previously using terraform apply to find these hidden bugs which made the debug loop pretty tiresome

@deansheather deansheather merged commit 45eb1b4 into main Jun 15, 2022
@deansheather deansheather deleted the dean/better-template-parse-errors branch June 15, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@deansheather @bpmct @kylecarbs