Skip to content

fix: Add --yes and --use-previous-options to config-ssh #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix: Add --yes and --use-previous-options to config-ssh #2458

merged 1 commit into from
Jun 17, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 17, 2022 •
edited
Loading

This PR adds support for --yes to coder config-ssh and --use-previous-options. The latter is needed for automations to avoid overwriting the users settings (e.g. --ssh-option ForwardAgent=yes).

See coder/jetbrains-coder#11.

@mafredri mafredri self-assigned this Jun 17, 2022
@mafredri mafredri requested a review from a team June 17, 2022 14:17
@mafredri mafredri changed the title fix: Add --yes and --keep-previous-options to config-ssh fix: Add --yes and --use-previous-options to config-ssh Jun 17, 2022
johnstcn
johnstcn approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love those tests!

@mafredri mafredri merged commit 18b0eff into main Jun 17, 2022
@mafredri mafredri deleted the mafredri/add-config-ssh-yes branch June 17, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @johnstcn