fix: chromatic schedule bug #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
commented
Jun 17, 2022
| {Language.autoStartDisplay(workspace.autostart_schedule)} | ||
| </span> | ||
| </div> | ||
| <div> | ||
| <span className={styles.scheduleLabel}>{Language.autoStopLabel}</span> | ||
| <span className={styles.scheduleValue} data-chromatic="ignore"> | ||
| <span className={[styles.scheduleValue, "chromatic-ignore"].join(" ")}> |
There was a problem hiding this comment.
combineClasses didn't like chromatic-ignore; that's a battle for another day, if this even works.
|
We haven't seen this issue for the last couple days so closing this for now. |
kylecarbs
approved these changes
Jun 23, 2022
AbhineetJain
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I'm not going to merge this until tomorrow when we can see if it actually fixes the snapshot tests (need a day change).
The snapshot tests for schedule were changing day to day, so we were constantly trying to have to accept new baselines. Attempting to ignore the culprit elements with the chromatic class suggested in the docs. We were using the attribute but that just wasn't doing the trick.