Skip to content

feat: unexpose coderdtest.NewWithAPI #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 27, 2022
Merged

feat: unexpose coderdtest.NewWithAPI #2613

merged 11 commits into from
Jun 27, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Jun 23, 2022

resolves #2584

@sreya sreya requested a review from a team as a code owner June 23, 2022 19:01
@sreya sreya removed the request for review from a team June 23, 2022 19:11
@sreya sreya force-pushed the jon/coderdtestapi branch from ed70004 to ed7e0e8 Compare June 24, 2022 19:50
@sreya sreya requested a review from kylecarbs June 24, 2022 23:14
kylecarbs
kylecarbs approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

@sreya sreya force-pushed the jon/coderdtestapi branch from f28d58e to 10127b2 Compare June 27, 2022 18:37
@sreya sreya merged commit 2353687 into main Jun 27, 2022
@sreya sreya deleted the jon/coderdtestapi branch June 27, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove database access from coderd_test
2 participants
@sreya @kylecarbs