Skip to content

docs: describe our telemetry #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2022
Merged

docs: describe our telemetry #2641

merged 4 commits into from
Oct 4, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Jun 24, 2022

This PR proposes features that do not yet exist. I figured we could use this PR as both production documentation and an RFC.

@ammario ammario requested review from bpmct and tjcran June 24, 2022 19:34
Copy link

@tjcran tjcran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammario I think this all makes sense and I agree with/like the approach. Other OSS has set the precedent of not having what you describe as level 0 ie you can't disable telemetry; but you can set it to an anonymized setting aka level 1. So I think the decision we have is whether we want to include level 0 in Enterprise or forego level 0 altogether.

I think having the ability to opt out entirely (even if it is only for Enterprise customers) is a good move. But I'm curious to see what others think.

@ammario
Copy link
Member Author

ammario commented Jun 24, 2022

@tjcran thanks for the review. For our customer base level 0 will be necessary. Perhaps it won't be default in the enterprise plan, but it will certainly be requested often.

@ammario
Copy link
Member Author

ammario commented Jun 24, 2022

@tjcran someone will need someone to build out the feature before I can merge this. I think that should be really easy though, as we just need to add email addresses and then the environment variable parsing.

@kylecarbs kylecarbs self-assigned this Jun 24, 2022
@coder coder deleted a comment from mafredri Jun 27, 2022
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think options 1 and 2 should have some sort of mention of the data we do collect. So like "this level collects product usage patterns, email and IP. This one only collect product usage patterns. This one collects nothing. " We can be vague here, but I was confused on the difference between 1 and 0 because it reads like we only collect email and IP.

@f0ssel
Copy link
Contributor

f0ssel commented Jun 28, 2022

Love the overall message and rationale here ❤️

@ammario
Copy link
Member Author

ammario commented Jul 21, 2022

Well, weren't we making it required? I think of this doc as kind of a commitment to the community so would rather merge it after we have these uncertainties worked out.

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jul 29, 2022
@github-actions github-actions bot closed this Aug 1, 2022
@ghuntley ghuntley reopened this Sep 7, 2022
@ghuntley ghuntley force-pushed the telemetry-docs branch 2 times, most recently from fc2c63c to 01c9735 Compare September 7, 2022 02:37
@ghuntley ghuntley requested a review from kylecarbs September 7, 2022 02:40
@ghuntley ghuntley removed the stale This issue is like stale bread. label Sep 7, 2022
@ghuntley ghuntley dismissed kylecarbs’s stale review September 12, 2022 09:23

no longer relevant

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Sep 20, 2022
@ghuntley ghuntley removed the stale This issue is like stale bread. label Sep 20, 2022
@kylecarbs kylecarbs removed their request for review September 23, 2022 00:42
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 1, 2022
@ghuntley ghuntley removed the stale This issue is like stale bread. label Oct 4, 2022
@ghuntley ghuntley enabled auto-merge (squash) October 4, 2022 03:57
@ghuntley ghuntley merged commit a1056bf into main Oct 4, 2022
@ghuntley ghuntley deleted the telemetry-docs branch October 4, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants