Skip to content

feat: Add allowlist of GitHub teams for OAuth #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2022
Merged

feat: Add allowlist of GitHub teams for OAuth #2849

merged 3 commits into from
Jul 9, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #2848.

@kylecarbs kylecarbs requested a review from coadler July 8, 2022 02:25
@kylecarbs kylecarbs self-assigned this Jul 8, 2022
Emyrk
Emyrk reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about where to parse the allow teams

@kylecarbs
Copy link
Member Author

@Emyrk fixed up!

@kylecarbs kylecarbs enabled auto-merge (squash) July 9, 2022 02:11
@kylecarbs kylecarbs disabled auto-merge July 9, 2022 02:36
@kylecarbs kylecarbs merged commit dff6e97 into main Jul 9, 2022
@kylecarbs kylecarbs deleted the githubteams branch July 9, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emyrk Emyrk Emyrk left review comments

@coadler coadler Awaiting requested review from coadler

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict GitHub OAuth based on GitHub teams?
2 participants
@kylecarbs @Emyrk