From b51a34cd1f9dfe9f1306eff17be37cef4350910a Mon Sep 17 00:00:00 2001 From: kylecarbs Date: Fri, 8 Jul 2022 02:29:17 +0000 Subject: [PATCH] fix: Always output job failure reason in provisioner daemon tests This flake can be seen here: https://github.com/coder/coder/runs/7186604615?check_suite_focus=true --- provisionerd/provisionerd_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go index 0b3626b8fae58..ecd4552ab8989 100644 --- a/provisionerd/provisionerd_test.go +++ b/provisionerd/provisionerd_test.go @@ -962,6 +962,14 @@ func createProvisionerd(t *testing.T, dialer provisionerd.Dialer, provisioners p // Creates a provisionerd protobuf client that's connected // to the server implementation provided. func createProvisionerDaemonClient(t *testing.T, server provisionerDaemonTestServer) proto.DRPCProvisionerDaemonClient { + if server.failJob == nil { + // Default to asserting the error from the failure, otherwise + // it can be lost in tests! + server.failJob = func(ctx context.Context, job *proto.FailedJob) (*proto.Empty, error) { + assert.Fail(t, job.Error) + return &proto.Empty{}, nil + } + } clientPipe, serverPipe := provisionersdk.TransportPipe() t.Cleanup(func() { _ = clientPipe.Close()