Skip to content

provisionersdk: extract and embed agent bootstrap scripts #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

johnstcn
Copy link
Member

This commit extracts the existing hard-coded agent scripts to their own files and embeds them using go:embed.
We can more easily use e.g. shellcheck to validate our agent scripts

@johnstcn johnstcn self-assigned this Jul 11, 2022
@johnstcn johnstcn requested a review from a team July 11, 2022 11:23
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely ❤️!

@johnstcn johnstcn merged commit 8a59178 into main Jul 11, 2022
@johnstcn johnstcn deleted the cj/gh-1544/extract-embed-agent-scripts branch July 11, 2022 11:43
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was very happy to see this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants