Skip to content

fix: Fetch GitHub teams by name for performance #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: Fetch GitHub teams by name for performance #2955

merged 1 commit into from
Jul 13, 2022

Conversation

kylecarbs
Copy link
Member

In large organizations with thousands of teams, looping took >5s.
This fetches organizations by team name, which should be very fast!

@kylecarbs
fix: Fetch GitHub teams by name for performance
c4e02a6 
In large organizations with thousands of teams, looping took >5s.
This fetches organizations by team name, which should be very fast!
@kylecarbs kylecarbs requested a review from coadler July 13, 2022 00:33
@kylecarbs kylecarbs self-assigned this Jul 13, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) July 13, 2022 00:41
@kylecarbs kylecarbs merged commit 8b76e40 into main Jul 13, 2022
@kylecarbs kylecarbs deleted the fetchsingleteam branch July 13, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler