Skip to content

fix: remove system user highlighting #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: remove system user highlighting #2973

merged 1 commit into from
Jul 13, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR removes the highlighting from the system user for workspace build initiators on the Workspace and Workspace Build pages.

Subtasks

  • Stop using the highlight color on the Workspace page.
  • Stop using the highlight color on the Workspace Build page.
  • Refactor code to stop returning color for the build initiator.
  • Update unit tests.

Screenshots

Workspace page

Screen Shot 2022-07-13 at 11 25 46 AM

Workspace Build page

Screen Shot 2022-07-13 at 11 26 09 AM

Fixes #2972

@AbhineetJain AbhineetJain requested a review from a team as a code owner July 13, 2022 18:26
presleyp
presleyp approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AbhineetJain AbhineetJain merged commit b692b7e into main Jul 13, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2972-remove-system-highlight branch July 13, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove highlighting for the system user as build initiator
2 participants
@AbhineetJain @presleyp