Skip to content

Return template parameters in consistent order #2975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Return template parameters in consistent order #2975

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cf8536
return parameters from Terraform provisioner in sorted order
dwahler Jul 13, 2022
bce2cf5
persist parameter indices in database and return them in correct orde…
dwahler Jul 13, 2022
a10c8c6
don't re-sort parameters by name when creating templates
dwahler Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
don't re-sort parameters by name when creating templates
  • Loading branch information
@dwahler
dwahler committed Jul 13, 2022
commit a10c8c66ae49adc14ba2c5eb512c10791ca95e2b
5 changes: 0 additions & 5 deletions cli/templatecreate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"fmt"
"os"
"path/filepath"
"sort"
"strings"
"time"

Expand Down Expand Up @@ -226,10 +225,6 @@ func createValidTemplateVersion(cmd *cobra.Command, args createValidTemplateVers
valuesBySchemaID[parameterValue.SchemaID.String()] = parameterValue
}

sort.Slice(parameterSchemas, func(i, j int) bool {
return parameterSchemas[i].Name < parameterSchemas[j].Name
})

// parameterMapFromFile can be nil if parameter file is not specified
var parameterMapFromFile map[string]string
if args.ParameterFile != "" {
Expand Down