Skip to content

feat: add verbose error messaging #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 20, 2022
Merged

feat: add verbose error messaging #3053

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72ae0ca
feat: add verbose error messaging
sreya Jul 12, 2022
eb57e7b
add a lil test
sreya Jul 13, 2022
1d65a42
fix not printing anything at all
sreya Jul 13, 2022
b9d8afc
add some more tests
sreya Jul 20, 2022
ae551a8
remove some test code
sreya Jul 20, 2022
e085a38
use var for suppress warning
sreya Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix not printing anything at all
  • Loading branch information
@sreya
sreya committed Jul 13, 2022
commit 1d65a42ebb85fbd9e3fc0ea3be30113a2276fe1b
4 changes: 3 additions & 1 deletion cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,9 @@ func FormatCobraError(err error, cmd *cobra.Command) string {
_, _ = fmt.Fprintln(&output, httpErr.Friendly())
}

if cliflag.IsSetBool(cmd, varVerbose) {
// If the httpErr is nil then we just have a regular error in which
// case we want to print out what's happening.
if httpErr == nil || cliflag.IsSetBool(cmd, varVerbose) {
_, _ = fmt.Fprintln(&output, err.Error())
}

Expand Down