Skip to content

fix: Add continue-on-error to codecov action step #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jul 20, 2022

Hopefully works around: codecov/codecov-action#788

Might bypass the failure, and makes sense not to trust the action with managing failure if we want to ignore it anyway.

@mafredri mafredri self-assigned this Jul 20, 2022
@mafredri mafredri requested a review from a team July 20, 2022 18:43
@dwahler
Copy link
Contributor

dwahler commented Jul 20, 2022

Might want to also remove the fail_ci_if_error parameter, so that the codecov step itself returns an error status and is visibly marked as failing, even if it doesn't cause the rest of the job to fail.

@mafredri
Copy link
Member Author

@dwahler It defaults to false, so we'd need to set it to true, actually. Also, issue seems to be resolved now (at least for ubuntu and macos runners so-far), but I don't think merging this would be a bad idea even then, thoughts?

@mafredri
Copy link
Member Author

@dwahler actually, I'm not brave enough to set fail_ci_if_error: true since I don't know by what mechanism it's going to fail the action. As-such, I just cleaned it up a bit and added a comment explaining it.

@mafredri mafredri enabled auto-merge (squash) July 20, 2022 19:04
@mafredri mafredri merged commit 96edc8a into main Jul 20, 2022
@mafredri mafredri deleted the mafredri/bypass-codecov-fail-check branch July 20, 2022 19:04
demisgomes added a commit to demisgomes/itimalia that referenced this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants