From 876e74b2b41b5503cde22d0bd38b717bed68ece5 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Wed, 20 Jul 2022 21:43:31 +0300 Subject: [PATCH 1/2] fix: Add `continue-on-error` to codecov action step Hopefully fixes: https://github.com/codecov/codecov-action/issues/788 --- .github/workflows/coder.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/coder.yaml b/.github/workflows/coder.yaml index 65622f5e2b13c..32f4be37228af 100644 --- a/.github/workflows/coder.yaml +++ b/.github/workflows/coder.yaml @@ -219,6 +219,7 @@ jobs: run: go run scripts/datadog-cireport/main.go gotests.xml - uses: codecov/codecov-action@v3 + continue-on-error: true if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork with: token: ${{ secrets.CODECOV_TOKEN }} @@ -281,6 +282,7 @@ jobs: run: go run scripts/datadog-cireport/main.go gotests.xml - uses: codecov/codecov-action@v3 + continue-on-error: true if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork with: token: ${{ secrets.CODECOV_TOKEN }} @@ -431,6 +433,7 @@ jobs: working-directory: site - uses: codecov/codecov-action@v3 + continue-on-error: true if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork with: token: ${{ secrets.CODECOV_TOKEN }} From 6f3bdb9d0c1484ff80db99794b064ba1aec773b7 Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Wed, 20 Jul 2022 21:55:47 +0300 Subject: [PATCH 2/2] chore: Add comment explaining codecov action failure --- .github/workflows/coder.yaml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/coder.yaml b/.github/workflows/coder.yaml index 32f4be37228af..53c60cc027fa1 100644 --- a/.github/workflows/coder.yaml +++ b/.github/workflows/coder.yaml @@ -219,14 +219,16 @@ jobs: run: go run scripts/datadog-cireport/main.go gotests.xml - uses: codecov/codecov-action@v3 + # This action has a tendency to error out unexpectedly, it has + # the `fail_ci_if_error` option that defaults to `false`, but + # that is no guarantee, see: + # https://github.com/codecov/codecov-action/issues/788 continue-on-error: true if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork with: token: ${{ secrets.CODECOV_TOKEN }} files: ./gotests.coverage flags: unittest-go-${{ matrix.os }} - # this flakes and sometimes fails the build - fail_ci_if_error: false test-go-postgres: name: "test/go/postgres" @@ -282,14 +284,16 @@ jobs: run: go run scripts/datadog-cireport/main.go gotests.xml - uses: codecov/codecov-action@v3 + # This action has a tendency to error out unexpectedly, it has + # the `fail_ci_if_error` option that defaults to `false`, but + # that is no guarantee, see: + # https://github.com/codecov/codecov-action/issues/788 continue-on-error: true if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork with: token: ${{ secrets.CODECOV_TOKEN }} files: ./gotests.coverage flags: unittest-go-postgres-${{ matrix.os }} - # this flakes and sometimes fails the build - fail_ci_if_error: false deploy: name: "deploy" @@ -433,14 +437,16 @@ jobs: working-directory: site - uses: codecov/codecov-action@v3 + # This action has a tendency to error out unexpectedly, it has + # the `fail_ci_if_error` option that defaults to `false`, but + # that is no guarantee, see: + # https://github.com/codecov/codecov-action/issues/788 continue-on-error: true if: github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork with: token: ${{ secrets.CODECOV_TOKEN }} files: ./site/coverage/lcov.info flags: unittest-js - # this flakes and sometimes fails the build - fail_ci_if_error: false - name: Upload DataDog Trace if: always() && github.actor != 'dependabot[bot]' && !github.event.pull_request.head.repo.fork