Skip to content

fix: storybook should use absolute paths #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

Kira-Pilot
Copy link
Member

@Kira-Pilot Kira-Pilot commented Jul 22, 2022

Chromatic/storybook was erroring when we used absolute paths. This PR hopefully fixes that issue.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner July 22, 2022 14:53
@Kira-Pilot
Copy link
Member Author

@AbhineetJain just fyi! 🤞 going forward we should be good to go.

Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good. 🙌

@Kira-Pilot Kira-Pilot merged commit 882ee55 into main Jul 22, 2022
@Kira-Pilot Kira-Pilot deleted the fix-chromatic-paths/kira-pilot branch July 22, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants