Skip to content

fix: coderd: putExtendWorkspace: move error from validation to message #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2022
Merged

fix: coderd: putExtendWorkspace: move error from validation to message #3289

merged 5 commits into from
Jul 29, 2022

Conversation

johnstcn
Copy link
Member

This PR:

  • refactors some error strings to variables
  • moves the validation error in putExtendWorkspace to the Message field so it shows up properly in the UI

@johnstcn johnstcn requested review from presleyp and a team July 29, 2022 10:49
@johnstcn johnstcn self-assigned this Jul 29, 2022
AbhineetJain
AbhineetJain approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we check a screenshot of how the new message looks in frontend for reference?

@johnstcn
Copy link
Member Author

Looks good! Can we check a screenshot of how the new message looks in frontend for reference?

image

@johnstcn johnstcn merged commit 4658b3f into main Jul 29, 2022
@johnstcn johnstcn deleted the cj/noissue/bumpers-errmsg branch July 29, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhineetJain AbhineetJain AbhineetJain approved these changes

@presleyp presleyp Awaiting requested review from presleyp

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @AbhineetJain