Skip to content

fix: Update issue reporting link with body #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fix: Update issue reporting link with body #3339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f18b7a9
fix: Update issue reporting link with body
kylecarbs Aug 1, 2022
53f5a4a
Merge branch 'main' into issuetemplate
kylecarbs Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Update issue reporting link with body 
The "Bug ..." title prefix didn't seem very useful. We have
labels to report a bug, and the version is rarely at play, since
we don't want to play a game of regression whack-a-mole.

This updates it to be mostly empty, which seems fine until we
have a problem.
  • Loading branch information
@kylecarbs
kylecarbs committed Aug 1, 2022
commit f18b7a9b620586a7e77aa5eccfd9bf460c634525
4 changes: 1 addition & 3 deletions site/src/components/Footer/Footer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ describe("Footer", () => {
throw new Error("Bug report link not found in footer")
}

expect(reportBugLink.getAttribute("href")).toBe(
`https://github.com/coder/coder/issues/new?labels=bug,needs+grooming&title=Bug+in+${MockBuildInfo.version}:&template=external_bug_report.md`,
)
expect(reportBugLink.getAttribute("href")?.length).toBeGreaterThan(0)
})
})
4 changes: 3 additions & 1 deletion site/src/components/Footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ export interface FooterProps {
export const Footer: React.FC<FooterProps> = ({ buildInfo }) => {
const styles = useFooterStyles()

const githubUrl = `https://github.com/coder/coder/issues/new?labels=bug,needs+grooming&title=Bug+in+${buildInfo?.version}:&template=external_bug_report.md`
const githubUrl = `https://github.com/coder/coder/issues/new?labels=needs+grooming&body=${encodeURIComponent(`Version: [\`${buildInfo?.version}\`](${buildInfo?.external_url})

<!--- Ask a question or leave feedback! -->`)}`

return (
<div className={styles.root}>
Expand Down