Skip to content

fix: handle create workspace errors #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 2, 2022
Merged

fix: handle create workspace errors #3346

merged 6 commits into from
Aug 2, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Aug 1, 2022 •
edited
Loading

This PR handles the errors encountered during the creation a new workspace.

Subtasks

  • assign and clear errors during the workflow
  • read these errors and display them using the ErrorSummary component.
  • add stories
  • update backend error message

Fixes #2842
Fixes #3343

Screenshots

Screen Shot 2022-08-01 at 4 07 59 PM

@AbhineetJain AbhineetJain requested a review from a team as a code owner August 1, 2022 20:12
@AbhineetJain
Copy link
Contributor Author

AbhineetJain commented Aug 1, 2022 •
edited
Loading

Storybook link: https://624de63c6aacee003aa84340-errlsywzjw.chromatic.com/?path=/story/pages-createworkspacepageview--create-workspace-error

Build: https://www.chromatic.com/build?appId=624de63c6aacee003aa84340&number=3738

@AbhineetJain AbhineetJain force-pushed the abhineetjain/create-workspace-errors branch from 7d648e6 to aaf9c25 Compare August 2, 2022 05:47
@AbhineetJain AbhineetJain force-pushed the abhineetjain/create-workspace-errors branch from aaf9c25 to c8977d3 Compare August 2, 2022 05:59
@AbhineetJain AbhineetJain mentioned this pull request Aug 2, 2022
Merged
@AbhineetJain AbhineetJain merged commit 8bcf23e into main Aug 2, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/create-workspace-errors branch August 2, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AbhineetJain @presleyp