fix: Use "virtual_machine_id" for instance identity with Azure #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using the wrong property, causing automatic auth to break.
spikecurtis
approved these changes
Aug 2, 2022
| "azurerm_linux_virtual_machine": "id", | ||
| "azurerm_windows_virtual_machine": "id", | ||
| "azurerm_linux_virtual_machine": "virtual_machine_id", | ||
| "azurerm_windows_virtual_machine": "virtual_machine_id", |
There was a problem hiding this comment.
I'm actually using azurerm_virtual_machine in the example template because azurerm_linux_virtual_machine doesn't support attaching the data disk before booting, meaning I can't format it in cloud-init
There was a problem hiding this comment.
Ahh, I'll add that as a resource as well.
There was a problem hiding this comment.
Spike discovered that the deprecated azurerm_virtual_machine resource exposes the machine ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using the wrong property, causing automatic auth to break.
Fixes #3315.