fix: Add ps.Kill/Wait to test cleanup in `ptytest.Start` #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mafredri merged 1 commit into main from mafredri/pty-start-windows-test

Aug 5, 2022

Member

mafredri commented Aug 5, 2022

A quick fix to ensure ptytest.Start cleans up after itself.

Prompted by a flake seen here: https://github.com/coder/coder/runs/7687803809


          fix: Add ps.Kill/Wait to test cleanup in ptytest.Start

443b222

mafredri self-assigned this

mafredri requested a review from a team

August 5, 2022 10:19

johnstcn approved these changes

View reviewed changes

mafredri merged commit 46d64c6 into main

mafredri deleted the mafredri/pty-start-windows-test branch

August 5, 2022 10:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet