feature: gate audit log by permissions #3464
Conversation
site/src/AppRouter.tsx
Outdated
| export const AppRouter: FC = () => { | ||
| const xServices = useContext(XServiceContext) | ||
| const [authState] = useActor(xServices.authXService) | ||
| const { permissions } = authState.context |
There was a problem hiding this comment.
This is probably a good place to use useSelector instead of useActor so that we don't get re-renders for anything except permissions. In fact, I think my plan was to do that within a wrapper component so that it only gets accessed on pages that need it - see RequireLicense here https://github.com/coder/coder/pull/3008/files#diff-8b4f166561cf1e9c08183827ef490e7741d6e79022122df7d835292bc3b3d0e7
There was a problem hiding this comment.
I'm realizing now that I was thinking about licensing instead of role-based permissions, but maybe it's still a good idea? Up to you!
There was a problem hiding this comment.
That is a good idea! I will play around with the wrapper component when I get to licensing, and make sure permissions go in there, too, if possible.
resolves #3460
Only admin and auditor roles should have access to the new audit log. This PR gates both the link in the nav bar as well as the route itself in case someone navigates directly.