Skip to content

feat: Add icon to templates #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 19, 2022
Merged

feat: Add icon to templates #3561

merged 10 commits into from
Aug 19, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #2221

@BrunoQuaresma BrunoQuaresma requested review from kylecarbs and a team August 18, 2022 18:57
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 18, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner August 18, 2022 19:02
kylecarbs
kylecarbs approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) August 18, 2022 20:56
@ammario
Copy link
Member

ammario commented Aug 19, 2022

I'm so excited for this!

@BrunoQuaresma
Copy link
Collaborator Author

@kylecarbs can you merge this please? I'm got some random errors from the last 3 times 😓

There are some problems with the configuration, described below.
Error: vision_test.go:365: log: [ERROR] 
Error: vision_test.go:365: log: [ERROR] The Terraform configuration must be valid before initialization so that
Error: vision_test.go:365: log: [ERROR] Terraform can determine which modules and providers need to be installed.
Error: vision_test.go:365: log: [ERROR] 
Error: vision_test.go:365: log: [ERROR] Error: Argument or block definition required
Error: vision_test.go:365: log: [ERROR] 
Error: vision_test.go:365: log: [ERROR] On main.tf line 1: An argument or block definition is required here. To set
Error: vision_test.go:365: log: [ERROR] an argument, use the equals sign "=" to introduce the argument value.

@BrunoQuaresma BrunoQuaresma merged commit 80f042f into main Aug 19, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-icon-field branch August 19, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @ammario @kylecarbs