Skip to content

GET license endpoint #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2022
Merged

GET license endpoint #3651

merged 3 commits into from
Aug 24, 2022

Conversation

spikecurtis
Copy link
Contributor

First PR of #3280

Next PR will add CLI command

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested a review from a team August 23, 2022 22:13
@@ -35,3 +35,18 @@ func (c *Client) AddLicense(ctx context.Context, r AddLicenseRequest) (License,
d.UseNumber()
return l, d.Decode(&l)
}

func (c *Client) GetLicenses(ctx context.Context) ([]License, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places we excluded the Get prefix. This could just be Licenses.

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis enabled auto-merge (squash) August 23, 2022 22:19
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis merged commit c9bce19 into main Aug 24, 2022
@spikecurtis spikecurtis deleted the spike/3280_get_licenses branch August 24, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants