Skip to content

fix: stop tracing static file server #3683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: stop tracing static file server #3683

merged 1 commit into from
Aug 25, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Aug 24, 2022

Some of these files take a while, skewing the percentiles and aren't valuable tracing data overall for us.

image

@f0ssel f0ssel requested a review from kylecarbs August 24, 2022 19:52
@f0ssel f0ssel enabled auto-merge (squash) August 24, 2022 19:52
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the apps being traced which will also include websockets. That is ok?

@f0ssel f0ssel merged commit a05fad4 into main Aug 25, 2022
@f0ssel f0ssel deleted the f0ssel/no-static-tracing branch August 25, 2022 13:38
@f0ssel
Copy link
Contributor Author

f0ssel commented Aug 25, 2022

I've manually ended the spans on a few routes like that, I'll hit the apps if the data shows them as problematic as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants