Skip to content

fix: remove (http.Server).ReadHeaderTimeout #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix: remove (http.Server).ReadHeaderTimeout #3730

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60b6dd5
fix: remove `(http.Server).ReadHeaderTimeout`
coadler Aug 29, 2022
2eda495
comment why disabled
coadler Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
comment why disabled
  • Loading branch information
@coadler
coadler committed Aug 29, 2022
commit 2eda495518c8ca24c7866694172cf275cad14b4d
9 changes: 9 additions & 0 deletions cli/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,11 @@ func Server(newAPI func(*coderd.Options) *coderd.API) *cobra.Command {

shutdownConnsCtx, shutdownConns := context.WithCancel(ctx)
defer shutdownConns()

// ReadHeaderTimeout is purposefully not enabled. It caused some issues with
// websockets over the dev tunnel.
// See: https://github.com/coder/coder/pull/3730
//nolint:gosec
server := &http.Server{
// These errors are typically noise like "TLS: EOF". Vault does similar:
// https://github.com/hashicorp/vault/blob/e2490059d0711635e529a4efcbaa1b26998d6e1c/command/server.go#L2714
Expand Down Expand Up @@ -1105,6 +1110,10 @@ func configureGithubOAuth2(accessURL *url.URL, clientID, clientSecret string, al
func serveHandler(ctx context.Context, logger slog.Logger, handler http.Handler, addr, name string) (closeFunc func()) {
logger.Debug(ctx, "http server listening", slog.F("addr", addr), slog.F("name", name))

// ReadHeaderTimeout is purposefully not enabled. It caused some issues with
// websockets over the dev tunnel.
// See: https://github.com/coder/coder/pull/3730
//nolint:gosec
srv := &http.Server{
Addr: addr,
Handler: handler,
Expand Down