From cdbf322fa69eef5aaca91e680ed88a69abd18711 Mon Sep 17 00:00:00 2001 From: Garrett Date: Thu, 1 Sep 2022 22:58:33 +0000 Subject: [PATCH 1/3] feat: add loaders to ssh and terminal buttons --- site/src/components/Resources/Resources.tsx | 7 +++++++ site/src/testHelpers/entities.ts | 18 +++++++++++++++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/site/src/components/Resources/Resources.tsx b/site/src/components/Resources/Resources.tsx index 97b63e519eec4..60c1c9e82625b 100644 --- a/site/src/components/Resources/Resources.tsx +++ b/site/src/components/Resources/Resources.tsx @@ -5,6 +5,7 @@ import TableCell from "@material-ui/core/TableCell" import TableContainer from "@material-ui/core/TableContainer" import TableHead from "@material-ui/core/TableHead" import TableRow from "@material-ui/core/TableRow" +import { Skeleton } from "@material-ui/lab" import useTheme from "@material-ui/styles/useTheme" import { ErrorSummary } from "components/ErrorSummary/ErrorSummary" import { TableCellDataPrimary } from "components/TableCellData/TableCellData" @@ -152,6 +153,12 @@ export const Resources: FC> = ({ ))} )} + {canUpdateWorkspace && agent.status === "connecting" && ( + <> + + + + )} diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts index c3013aff41ad6..505461cdda8a6 100644 --- a/site/src/testHelpers/entities.ts +++ b/site/src/testHelpers/entities.ts @@ -329,8 +329,16 @@ export const MockWorkspaceAgentOutdated: TypesGen.WorkspaceAgent = { operating_system: "Windows", } +export const MockWorkspaceAgentConnecting: TypesGen.WorkspaceAgent = { + ...MockWorkspaceAgent, + id: "test-workspace-agent-2", + name: "another-workspace-agent", + status: "connecting", + version: "", +} + export const MockWorkspaceResource: TypesGen.WorkspaceResource = { - agents: [MockWorkspaceAgent, MockWorkspaceAgentDisconnected, MockWorkspaceAgentOutdated], + agents: [MockWorkspaceAgent, MockWorkspaceAgentConnecting, MockWorkspaceAgentOutdated], created_at: "", id: "test-workspace-resource", job_id: "", @@ -343,10 +351,14 @@ export const MockWorkspaceResource: TypesGen.WorkspaceResource = { ], } -export const MockWorkspaceResource2 = { - ...MockWorkspaceResource, +export const MockWorkspaceResource2: TypesGen.WorkspaceResource = { + agents: [MockWorkspaceAgent, MockWorkspaceAgentDisconnected, MockWorkspaceAgentOutdated], + created_at: "", id: "test-workspace-resource-2", + job_id: "", name: "another-workspace-resource", + type: "google_compute_disk", + workspace_transition: "start", metadata: [ { key: "type", value: "google_compute_disk", sensitive: false }, { key: "size", value: "32GB", sensitive: false }, From 259c3966161c7f1ef93a55a1bfa3e0dbfde8a462 Mon Sep 17 00:00:00 2001 From: Garrett Date: Thu, 1 Sep 2022 23:16:07 +0000 Subject: [PATCH 2/3] fix test --- site/src/pages/WorkspacePage/WorkspacePage.test.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx index 12c67b7d455c4..b6c26b44a3a4b 100644 --- a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx +++ b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx @@ -20,6 +20,7 @@ import { MockWorkspace, MockWorkspaceAgent, MockWorkspaceAgentDisconnected, + MockWorkspaceAgentConnecting, MockWorkspaceBuild, renderWithAuth, } from "../../testHelpers/renderHelpers" @@ -205,10 +206,14 @@ describe("WorkspacePage", () => { DisplayAgentStatusLanguage[MockWorkspaceAgent.status], ) expect(agent1Status.length).toEqual(4) - const agent2Status = await screen.findAllByText( + const agentDisconnected = await screen.findAllByText( DisplayAgentStatusLanguage[MockWorkspaceAgentDisconnected.status], ) - expect(agent2Status.length).toEqual(2) + expect(agentDisconnected.length).toEqual(1) + const agentConnecting = await screen.findAllByText( + DisplayAgentStatusLanguage[MockWorkspaceAgentConnecting.status], + ) + expect(agentConnecting.length).toEqual(1) expect(getTemplateMock).toBeCalled() }) }) From 89a1078a7bc649fd4ce135ad0acab8dfaa2331f7 Mon Sep 17 00:00:00 2001 From: Garrett Date: Thu, 1 Sep 2022 23:22:33 +0000 Subject: [PATCH 3/3] make fmt --- site/src/pages/WorkspacePage/WorkspacePage.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx index b6c26b44a3a4b..c6754ab026fd1 100644 --- a/site/src/pages/WorkspacePage/WorkspacePage.test.tsx +++ b/site/src/pages/WorkspacePage/WorkspacePage.test.tsx @@ -19,8 +19,8 @@ import { MockTemplate, MockWorkspace, MockWorkspaceAgent, - MockWorkspaceAgentDisconnected, MockWorkspaceAgentConnecting, + MockWorkspaceAgentDisconnected, MockWorkspaceBuild, renderWithAuth, } from "../../testHelpers/renderHelpers"