feat: Add audit log filters #4078
Conversation
|
Opening to receiving initial feedback on the API side. |
| var params []string | ||
| if req.SearchQuery != "" { | ||
| params = append(params, req.SearchQuery) | ||
| } | ||
| q.Set("q", strings.Join(params, " ")) |
There was a problem hiding this comment.
I'm slightly confused with params. It seems like it can only ever have 0 or 1 elements. Why do we need to strings.Join it?
There was a problem hiding this comment.
Good catch, I copied and paste from the workspace logic.
There was a problem hiding this comment.
Thinking better, it could have resource_type:workspace action:create right?
There was a problem hiding this comment.
Is this where we're defining the name of the param? Do we have control over calling it q or something else?
| var params []string | ||
| if req.SearchQuery != "" { | ||
| params = append(params, req.SearchQuery) | ||
| } | ||
| q.Set("q", strings.Join(params, " ")) |
There was a problem hiding this comment.
Is this where we're defining the name of the param? Do we have control over calling it q or something else?
|
@kylecarbs how would you expect to use the "Resource ID" in the filtering? Just a text input? 🤔 wondering if we could provide a better experience. |
|
I'd do it with a filter, similar to this PR. |
The back-end part of #4077