Skip to content

feat: Add audit log filters #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 19, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test cases
  • Loading branch information
BrunoQuaresma committed Sep 16, 2022
commit d407d9b6503b35a5dbeee4f5b39e12c998469f9b
58 changes: 40 additions & 18 deletions coderd/audit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,32 +59,54 @@ func TestAuditLogsFilter(t *testing.T) {
ResourceType: codersdk.ResourceTypeUser,
})
require.NoError(t, err)

// Create one log with "Delete"
err = client.CreateTestAuditLog(ctx, codersdk.CreateTestAuditLogRequest{
Action: codersdk.AuditActionDelete,
ResourceType: codersdk.ResourceTypeUser,
})
require.NoError(t, err)

// Verify the number of create logs
actionCreateLogs, err := client.AuditLogs(ctx, codersdk.AuditLogsRequest{
SearchQuery: "action:create",
Pagination: codersdk.Pagination{
Limit: 25,
// Test cases
testCases := []struct {
Name string
SearchQuery string
ExpectedResult int
}{
{
Name: "FilterByCreateAction",
SearchQuery: "action:create",
ExpectedResult: 2,
},
})
require.NoError(t, err)
require.Len(t, actionCreateLogs.AuditLogs, 2)

// Verify the number of delete logs
actionDeleteLogs, err := client.AuditLogs(ctx, codersdk.AuditLogsRequest{
SearchQuery: "action:delete",
Pagination: codersdk.Pagination{
Limit: 25,
{
Name: "FilterByDeleteAction",
SearchQuery: "action:delete",
ExpectedResult: 1,
},
})

require.NoError(t, err)
require.Len(t, actionDeleteLogs.AuditLogs, 1)
{
Name: "FilterByUserResourceType",
SearchQuery: "resource_type:user",
ExpectedResult: 2,
},
{
Name: "FilterByTemplateResourceType",
SearchQuery: "resource_type:template",
ExpectedResult: 1,
},
}

for _, testCase := range testCases {
t.Run(testCase.Name, func(t *testing.T) {
t.Parallel()
auditLogs, err := client.AuditLogs(ctx, codersdk.AuditLogsRequest{
SearchQuery: testCase.SearchQuery,
Pagination: codersdk.Pagination{
Limit: 25,
},
})
require.NoError(t, err, "fetch audit logs")
require.Len(t, auditLogs.AuditLogs, testCase.ExpectedResult, "expected audit logs returned")
})
}
})
}