Skip to content

fix: Improve consistency on CLI help #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: Improve consistency on CLI help #4112

merged 1 commit into from
Sep 19, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Sep 19, 2022

This makes the english consistent on flags, and improves the contrast for the placeholder color on dark themes.

Before:
image

After:
image

This makes the english consistent on flags, and improves
the contrast for the placeholder color on dark themes.
@kylecarbs kylecarbs requested a review from bpmct September 19, 2022 16:01
@kylecarbs kylecarbs self-assigned this Sep 19, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) September 19, 2022 16:02
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the wording changes are a huge improvement!

Wondering if we should link to our own documentation here for STUN, GitHub OAuth, and OIDC 🤷🏼

@kylecarbs kylecarbs merged commit 6f82ad0 into main Sep 19, 2022
@kylecarbs kylecarbs deleted the cmdhelp branch September 19, 2022 16:36
@kylecarbs
Copy link
Member Author

Hmm... we probably should

@bpmct
Copy link
Member

bpmct commented Sep 19, 2022

I'll take care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants