Skip to content

feat: Add browser-only connections to Enterprise #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2022
Merged

feat: Add browser-only connections to Enterprise #4135

merged 6 commits into from
Sep 22, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Sep 20, 2022

Fixes #4131.

This adds a feature to disable all non-browser connections to Coder. When attempting to SSH, speed test, or port-forward, the following message is printed: "Non-browser connections are disabled for your deployment."

I still have to hide the SSH button in the UI if this is disabled.

@kylecarbs kylecarbs requested review from deansheather, bpmct and sreya and removed request for deansheather September 20, 2022 18:16
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna write docs real quick
nvm missed it

@bpmct bpmct self-requested a review September 20, 2022 18:27
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@kylecarbs kylecarbs requested a review from a team as a code owner September 20, 2022 19:49
@kylecarbs kylecarbs requested review from BrunoQuaresma and removed request for a team September 20, 2022 19:49
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE LGTM

@kylecarbs kylecarbs merged commit 7ad4276 into main Sep 22, 2022
@kylecarbs kylecarbs deleted the disablessh branch September 22, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enterprise feature: Ability for administrators to disable SSH for groups or site-wide
3 participants