Skip to content

chore(site): remove some eslint-disables #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2022
Merged

chore(site): remove some eslint-disables #4265

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ceda4ea
fix: await promises in WorkspacePage.test.tsx
jsjoeio Sep 29, 2022
3b280d4
chore: add eventsourcemock to cspell words
jsjoeio Sep 29, 2022
27be8c2
fix: clean up UsersPage.test.tsx
jsjoeio Sep 29, 2022
a4769d8
refactor: clean up eventsource mock
jsjoeio Sep 29, 2022
83e3583
revert: remove changes from WorkspacePage.test.tsx
jsjoeio Sep 29, 2022
5b4aa3a
Merge branch 'main' into jsjoeio/site-fixes
jsjoeio Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: await promises in WorkspacePage.test.tsx
  • Loading branch information
@jsjoeio
jsjoeio committed Sep 29, 2022
commit ceda4ea83d942547cbba18bdfa748c313296d032
5 changes: 2 additions & 3 deletions site/src/pages/WorkspacePage/WorkspacePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-floating-promises */
import { fireEvent, screen, waitFor } from "@testing-library/react"
import userEvent from "@testing-library/user-event"
import EventSource from "eventsourcemock"
Expand Down Expand Up @@ -94,7 +93,7 @@ describe("WorkspacePage", () => {
const stopWorkspaceMock = jest
.spyOn(api, "stopWorkspace")
.mockResolvedValueOnce(MockWorkspaceBuild)
testButton(Language.stop, stopWorkspaceMock)
await testButton(Language.stop, stopWorkspaceMock)
})

it("requests a delete job when the user presses Delete and confirms", async () => {
Expand Down Expand Up @@ -128,7 +127,7 @@ describe("WorkspacePage", () => {
const startWorkspaceMock = jest
.spyOn(api, "startWorkspace")
.mockImplementation(() => Promise.resolve(MockWorkspaceBuild))
testButton(Language.start, startWorkspaceMock)
await testButton(Language.start, startWorkspaceMock)
})
it("requests cancellation when the user presses Cancel", async () => {
server.use(
Expand Down