refactor: clean up types in jest.setup.ts #4285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
commented
Sep 30, 2022
| @@ -38,16 +38,12 @@ afterAll(() => server.close()) | |||
| // For now, I limited this to just 'error' - but failing on warnings | |||
| // would be a nice next step! We may need to filter out some noise | |||
| // from material-ui though. | |||
| const CONSOLE_FAIL_TYPES = ["error" /* 'warn' */] | |||
| const CONSOLE_FAIL_TYPES = ["error" /* 'warn' */] as const | |||
There was a problem hiding this comment.
Using as const narrows the type to string literals which is more correct.
| const consoleAsAny = global.console as any | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| consoleAsAny[logType] = (format: string, ...args: any[]): void => { | ||
| CONSOLE_FAIL_TYPES.forEach((logType: typeof CONSOLE_FAIL_TYPES[number]) => { |
There was a problem hiding this comment.
here logType is limited to the options we specify in CONSOLE_FAIL_TYPES.
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| consoleAsAny[logType] = (format: string, ...args: any[]): void => { | ||
| CONSOLE_FAIL_TYPES.forEach((logType: typeof CONSOLE_FAIL_TYPES[number]) => { | ||
| global.console[logType] = <Type>(format: string, ...args: Type[]): void => { |
There was a problem hiding this comment.
Using the generic, we no longer need to use any.
Kira-Pilot
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some of the types in
jest.setup.ts.