fix: add keys to createCtas elements #4362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
commented
Oct 4, 2022
| // REMARK: we don't have to worry about key order changing | ||
| // eslint-disable-next-line react/jsx-key | ||
| return [<CopyStackButton text={codeBlock.join("\r\n")} />, <ReloadAppButton />] | ||
| return [<CopyStackButton key="copy-stack-btn" text={codeBlock.join("\r\n")} />, <ReloadAppButton key="reload-app-btn" />] |
There was a problem hiding this comment.
I know it says they won't change but I decided to add them because:
- no negative impact adding them
- good codebase hygiene to avoid using
eslint-disable
Plus, in some edge case if React does render them in a different order, it can tell the difference based on key.
presleyp
approved these changes
Oct 4, 2022
|
Fixing formatting right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.