From d97c18824fa1aa57bcbb0000e12e5744a3b487cb Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Tue, 4 Oct 2022 16:36:49 +0000 Subject: [PATCH 1/2] fix: add keys to createCtas elements --- site/src/components/RuntimeErrorState/createCtas.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/site/src/components/RuntimeErrorState/createCtas.tsx b/site/src/components/RuntimeErrorState/createCtas.tsx index 977c46eab6994..ccfeced6aebc5 100644 --- a/site/src/components/RuntimeErrorState/createCtas.tsx +++ b/site/src/components/RuntimeErrorState/createCtas.tsx @@ -48,9 +48,7 @@ const ReloadAppButton = (): ReactElement => { * createCtas generates an array of buttons to be used with our error boundary UI */ export const createCtas = (codeBlock: string[]): ReactElement[] => { - // REMARK: we don't have to worry about key order changing - // eslint-disable-next-line react/jsx-key - return [, ] + return [, ] } const useStyles = makeStyles((theme) => ({ From 3c514db746204146e170f91256a0d960bed96df2 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Tue, 4 Oct 2022 16:40:20 +0000 Subject: [PATCH 2/2] fixup: formatting --- site/src/components/RuntimeErrorState/createCtas.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/site/src/components/RuntimeErrorState/createCtas.tsx b/site/src/components/RuntimeErrorState/createCtas.tsx index ccfeced6aebc5..5314441166892 100644 --- a/site/src/components/RuntimeErrorState/createCtas.tsx +++ b/site/src/components/RuntimeErrorState/createCtas.tsx @@ -48,7 +48,10 @@ const ReloadAppButton = (): ReactElement => { * createCtas generates an array of buttons to be used with our error boundary UI */ export const createCtas = (codeBlock: string[]): ReactElement[] => { - return [, ] + return [ + , + , + ] } const useStyles = makeStyles((theme) => ({