Skip to content

chore: replace old ErrorSummary component #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2022
Merged

chore: replace old ErrorSummary component #4417

merged 3 commits into from
Oct 7, 2022

Conversation

Kira-Pilot
Copy link
Member

Since we introduced the AlertBanner, we can rip out the old ErrorSummary component and use that instead.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner October 7, 2022 15:26
@Kira-Pilot Kira-Pilot requested review from jsjoeio and removed request for a team October 7, 2022 15:26
jsjoeio
jsjoeio approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I didn't look at Chromatic but I assume you checked these and everything renders okay still?

@Kira-Pilot
Copy link
Member Author

Nice work! I didn't look at Chromatic but I assume you checked these and everything renders okay still?

@jsjoeio thanks! yup, you can take a look here if you're curious. The expander caret is correctly positioned now.

@Kira-Pilot Kira-Pilot merged commit 257df81 into main Oct 7, 2022
@Kira-Pilot Kira-Pilot deleted the replace-error-summary/kira-pilot branch October 7, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kira-Pilot @jsjoeio