fix: redesign schedule bumper to handle multiple hours of change at once #4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
code-asher
approved these changes
Oct 14, 2022
|
I'm gonna merge because I'm working on something higher priority now, but I like those ideas! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3566
Previously, if you clicked the + or - icon on the workspace page multiple times in a row, it would only change the stop time by one hour. Now, clicking + enters addition mode and clicking - enters subtraction mode. Either mode displays an hours input with stepper controls and a Set button. You can type the number of hours you want to add/subtract, or click the stepper or arrow up/down. Then click Set. One hour is the default. Setting a change of 0 hours sends no event, it's like canceling. This way, users can adjust their auto-stop time without opening the Schedule Page and relative to their planned auto-stop time rather than (as on the Schedule Page) relative to their start time.
Kapture.2022-10-12.at.10.18.46.mp4
Mobile layout:
