Skip to content

Rename the noVNC icon to match the other icons #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

Rename the noVNC icon to match the other icons #4574

merged 1 commit into from
Oct 17, 2022

Conversation

phorcys420
Copy link
Member

This is a very basic PR but it frustrates me that the filename is novnc-icon.svg so I fixed it

@phorcys420 phorcys420 requested a review from a team as a code owner October 16, 2022 20:14
@phorcys420 phorcys420 requested review from BrunoQuaresma and removed request for a team October 16, 2022 20:14
@github-actions
Copy link

github-actions bot commented Oct 16, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@phorcys420
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@phorcys420
Copy link
Member Author

phorcys420 commented Oct 16, 2022 •
edited
Loading

just realised I forgot to add the file, so what I did was just deleting the noVNC icon. 😅
(fixed in that force-push)

@kylecarbs kylecarbs merged commit ee2c29d into coder:main Oct 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@BrunoQuaresma BrunoQuaresma Awaiting requested review from BrunoQuaresma BrunoQuaresma was automatically assigned from coder/ts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phorcys420 @kylecarbs