Skip to content

Revert "Revert "feat: Support config files with viper"" #4693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2022
Merged

Revert "Revert "feat: Support config files with viper"" #4693

merged 2 commits into from
Oct 21, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Oct 21, 2022

Reverts #4692

@f0ssel f0ssel requested a review from a team as a code owner October 21, 2022 20:38
@f0ssel f0ssel requested review from jsjoeio and removed request for a team October 21, 2022 20:38
kylecarbs
kylecarbs approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed?

@f0ssel
Copy link
Contributor Author

f0ssel commented Oct 21, 2022

The default replacer was not mapping correctly to env vars with . in the path, so I updated it - cbfecaf#diff-4e5ee1b09c126fffa885a25d3c78c398fd65e9075915523090ce206270d80bbeR365

@f0ssel
Copy link
Contributor Author

f0ssel commented Oct 21, 2022

On dev.coder.com we are properly setting CODER_TLS_ENABLE but we would look for CODER_TLS.ENABLE or something like that. I tested this tls case specifically and it works, and I'll have another round of tests go in with my futher work.

@f0ssel f0ssel enabled auto-merge (squash) October 21, 2022 20:48
@f0ssel f0ssel merged commit 372fb1f into main Oct 21, 2022
@f0ssel f0ssel deleted the revert-4692-revert-4558-f0ssel/cli-gen branch October 21, 2022 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f0ssel @jsjoeio @kylecarbs