Skip to content

feat(setup): organization is not longer needed #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Oct 23, 2022

Resolves (in theory) #4697

@ghuntley ghuntley requested a review from a team as a code owner October 23, 2022 16:11
@ghuntley ghuntley requested review from Kira-Pilot and removed request for a team October 23, 2022 16:11
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this one! It seems to me that the API is asking we send down an organization. You can see where we send down data of this type in api.ts.

Not sure what needs to be altered server-side here, but we'll need to regenerate those types after a change is made so that lint stops complaining.

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 1, 2022
@ghuntley ghuntley removed the stale This issue is like stale bread. label Nov 4, 2022
@ghuntley ghuntley marked this pull request as draft November 11, 2022 03:27
@ghuntley ghuntley marked this pull request as ready for review November 14, 2022 02:01
@ghuntley
Copy link
Contributor Author

I went back in there and removed all backend references. Would appreciate a second set of eyes on this one as first time making backend+frontend changes in the project.

@ghuntley ghuntley requested a review from mafredri November 14, 2022 02:01
{...getFieldHelpers("organization")}
onChange={onChangeTrimmed(form)}
autoFocus
fullWidth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to give autoFocus to the next field so that users can start typing without clicking into the form.

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE ✅

@ghuntley ghuntley closed this Nov 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
@github-actions github-actions bot deleted the gh/setup-org branch May 12, 2023 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants