From 52d45fc2e5f4da9e8c583ed076e9f04dbba20a15 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 24 Oct 2022 22:02:38 +0000 Subject: [PATCH 1/2] chore: drop eslint-disable rule --- .../components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx b/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx index 50170886c62d7..3a65036188ec6 100644 --- a/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx +++ b/site/src/components/WorkspaceScheduleForm/WorkspaceScheduleForm.tsx @@ -99,7 +99,6 @@ export interface WorkspaceScheduleFormValues { ttl: number } -// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types export const validationSchema = Yup.object({ sunday: Yup.boolean(), monday: Yup.boolean().test( From 655fffaaede866a2f6845146f4e9e59cf1c0890b Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 24 Oct 2022 22:02:54 +0000 Subject: [PATCH 2/2] refactor: add types for makeMockApiError --- site/src/testHelpers/entities.ts | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts index 9f0e8c662af37..d02f8bfd5b60f 100644 --- a/site/src/testHelpers/entities.ts +++ b/site/src/testHelpers/entities.ts @@ -814,15 +814,29 @@ export const MockCancellationMessage = { message: "Job successfully canceled", } -// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types -export const makeMockApiError = ({ - message, - detail, - validations, -}: { +type MockAPIInput = { message?: string detail?: string validations?: FieldError[] +} + +type MockAPIOutput = { + response: { + data: { + message: string + detail: string | undefined + validations: FieldError[] | undefined + } + } + isAxiosError: boolean +} + +type MakeMockApiErrorFunction = (input: MockAPIInput) => MockAPIOutput + +export const makeMockApiError: MakeMockApiErrorFunction = ({ + message, + detail, + validations, }) => ({ response: { data: {