refactor: Make the audit log looks like a timeline #4765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presleyp
reviewed
Oct 26, 2022
presleyp
reviewed
Oct 26, 2022
| const styles = useStyles() | ||
| // We only want the message related to the date since the time is displayed | ||
| // inside of the build row | ||
| const displayDate = formatRelative(date, new Date()).split("at")[0] |
There was a problem hiding this comment.
is this something dayjs can't do?
There was a problem hiding this comment.
No, it does not 😞 . I mean, I tried to find it in their docs but I didn't find anything.
presleyp
reviewed
Oct 26, 2022
| @@ -37,6 +37,27 @@ const presetFilters = [ | |||
| { query: "resource_type:user action:delete", name: "Deleted users" }, | |||
| ] | |||
|
|
|||
| const groupAuditLogsByDate = (auditLogs?: AuditLog[]) => { | |||
There was a problem hiding this comment.
if you're willing to use lodash I think this would just be
_.groupBy(auditLogs, (log) => new Date(log.time).toDateString())
There was a problem hiding this comment.
Yes, I think we could talk about adding lodash since we can import specific functions only instead of the entire package.
There was a problem hiding this comment.
I think we already have it because it comes bundled with something else
presleyp
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
