Skip to content

feat: Associate connected workspace agents with replicas #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

kylecarbs
Copy link
Member

This will enable displaying a graph that associates agents to running replicas.

This will enable displaying a graph that associates agents
to running replicas.
@kylecarbs kylecarbs requested a review from coadler November 6, 2022 17:30
@kylecarbs kylecarbs self-assigned this Nov 6, 2022
Comment on lines +1 to +2
ALTER TABLE workspace_agents
ADD COLUMN last_connected_replica_id uuid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to make this not null with a default '00000000-0000-0000-0000-000000000000'::uuid since in practice this should never be null.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be null if the agent hasn't connected yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good point

@kylecarbs kylecarbs merged commit 5be6c70 into main Nov 6, 2022
@kylecarbs kylecarbs deleted the agentreplica branch November 6, 2022 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants