diff --git a/site/src/components/TemplateLayout/TemplateLayout.tsx b/site/src/components/TemplateLayout/TemplateLayout.tsx index 8363fcdd7bed5..7567d572207ef 100644 --- a/site/src/components/TemplateLayout/TemplateLayout.tsx +++ b/site/src/components/TemplateLayout/TemplateLayout.tsx @@ -106,35 +106,23 @@ export const TemplateLayout: FC = ({ children }) => { organizationId, }, }) - const { - template, - activeTemplateVersion, - templateResources, - templateDAUs, - permissions: templatePermissions, - } = templateState.context + const { template, permissions: templatePermissions } = templateState.context const xServices = useContext(XServiceContext) const permissions = useSelector(xServices.authXService, selectPermissions) - const isLoading = - !template || - !activeTemplateVersion || - !templateResources || - !permissions || - !templateDAUs || - !templatePermissions - const hasIcon = template && template.icon && template.icon !== "" + if (!template) { + return + } + const generatePageHeaderActions = (): JSX.Element[] => { const pageActions: JSX.Element[] = [] - if (!isLoading && templatePermissions.canUpdateTemplate) { - pageActions.push() + if (templatePermissions?.canUpdateTemplate) { + pageActions.push() } - if (!isLoading) { - pageActions.push() - } + pageActions.push() return pageActions } @@ -152,65 +140,59 @@ export const TemplateLayout: FC = ({ children }) => { } > - {!isLoading && ( -
- {hasIcon ? ( -
- -
- ) : ( - - {firstLetter(templateName)} - - )} -
- )} +
+ {hasIcon ? ( +
+ +
+ ) : ( + + {firstLetter(template.name)} + + )} +
- {!isLoading && ( -
- {templateName} - - {template.description === "" - ? Language.noDescription - : template.description} - -
- )} +
+ {template.name} + + {template.description === "" + ? Language.noDescription + : template.description} + +
- {!isLoading && ( -
- - - - combineClasses([ - styles.tabItem, - isActive ? styles.tabItemActive : undefined, - ]) - } - > - Summary - - - combineClasses([ - styles.tabItem, - isActive ? styles.tabItemActive : undefined, - ]) - } - > - Permissions - - - -
- )} +
+ + + + combineClasses([ + styles.tabItem, + isActive ? styles.tabItemActive : undefined, + ]) + } + > + Summary + + + combineClasses([ + styles.tabItem, + isActive ? styles.tabItemActive : undefined, + ]) + } + > + Permissions + + + +
@@ -26,14 +25,11 @@ export const TemplatePermissionsPage: FC< context: { templateId: template?.id }, }) const { templateACL, userToBeUpdated, groupToBeUpdated } = state.context - if (!template || !permissions) { - return - } return ( <> - {pageTitle(`${template.name} · Permissions`)} + {pageTitle(`${template?.name} · Permissions`)} @@ -68,7 +64,7 @@ export const TemplatePermissionsPage: FC< { send("ADD_USER", { user, role, onDone: reset }) }} diff --git a/site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPage.test.tsx b/site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPage.test.tsx index bfad63f8f0b5a..cc36c9595930d 100644 --- a/site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPage.test.tsx +++ b/site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPage.test.tsx @@ -38,7 +38,7 @@ describe("TemplateSummaryPage", () => { renderPage() await screen.findByText(MockTemplate.name) - screen.getByTestId("markdown") + await screen.findByTestId("markdown") screen.getByText(MockWorkspaceResource.name) screen.queryAllByText(`${MockTemplateVersion.name}`).length })