Skip to content

chore: refactor agent stats streaming #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Nov 17, 2022

Agents no longer use a websocket for streaming stats, and instead use the returned interval to determine when to send the next stat.

Network stats are retrieved directly from Tailscale, getting rid of the need to wrap network connections.

@coadler coadler force-pushed the colin/agent-stats-streaming branch 8 times, most recently from 314d7e8 to a983aa2 Compare November 17, 2022 22:40
Agents no longer use a websocket for streaming stats, and instead use
the returned interval to determine when to send the next stat.

Network stats are retrieved directly from Tailscale, getting rid of the
need to wrap network connections.
@coadler coadler force-pushed the colin/agent-stats-streaming branch from 8b793c9 to d397b86 Compare November 18, 2022 01:29
@coadler coadler marked this pull request as ready for review November 18, 2022 01:34
@coadler coadler self-assigned this Nov 18, 2022
@coadler coadler requested review from ammario and kylecarbs November 18, 2022 01:34
@ammario ammario removed their request for review November 18, 2022 01:45
@coadler coadler requested a review from deansheather November 18, 2022 06:00
@coadler coadler merged commit ae38bbe into main Nov 18, 2022
@coadler coadler deleted the colin/agent-stats-streaming branch November 18, 2022 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants