Skip to content

fix: Trigger workspace event after agent timeout seconds #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2022
Merged

fix: Trigger workspace event after agent timeout seconds #5141

merged 3 commits into from
Nov 22, 2022

Conversation

mafredri
Copy link
Member

Fixes #5116

@mafredri mafredri self-assigned this Nov 21, 2022
@mafredri mafredri changed the title fix: Trigger workspace even after agent timeout seconds fix: Trigger workspace event after agent timeout seconds Nov 21, 2022
BrunoQuaresma
BrunoQuaresma reviewed Nov 21, 2022
View reviewed changes
BrunoQuaresma
BrunoQuaresma approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code makes sense to me. I'm not a BE expert but since you added tests it is safe to merge IMO 👍

johnstcn
johnstcn reviewed Nov 22, 2022
View reviewed changes
johnstcn
johnstcn reviewed Nov 22, 2022
View reviewed changes
johnstcn
johnstcn reviewed Nov 22, 2022
View reviewed changes
johnstcn
johnstcn reviewed Nov 22, 2022
View reviewed changes
@mafredri mafredri enabled auto-merge (squash) November 22, 2022 10:45
@mafredri mafredri merged commit 2b6c229 into main Nov 22, 2022
@mafredri mafredri deleted the mafredri/propagate-agent-connection-timeout branch November 22, 2022 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@johnstcn johnstcn johnstcn approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I have to refresh to see that agent is disconnected
3 participants
@mafredri @BrunoQuaresma @johnstcn